fix bug in wasi::environ_get, fix off by one error in env_size_get #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great finding. I think it will be good to:
|
syrusakbary
reviewed
May 30, 2019
| println!("Env vars:"); | ||
| for e in env_vars { | ||
| println!("{}", e); | ||
| } |
There was a problem hiding this comment.
It might be useful to add case to retrieve a single env var when:
- env var is present (such as
DOG) - env var is not present (such as
UNKNOWN)
|
bors try |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 30, 2019
476: fix bug in wasi::environ_get, fix off by one error in env_size_get r=MarkMcCaskey a=MarkMcCaskey adds `--env` flag (resolves #475) fixes other wasi env bugs adds wasi envvar test Co-authored-by: Mark McCaskey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
--envflag (resolves #475)fixes other wasi env bugs
adds wasi envvar test